Skip to content

Comments

[AIROCMLIR-185] Enable rocmlir-tuning-driver for fat-lib / static builds#2251

Open
dorde-antic wants to merge 2 commits intodevelopfrom
AIROCMLIR-185-code-coverage-is-broken
Open

[AIROCMLIR-185] Enable rocmlir-tuning-driver for fat-lib / static builds#2251
dorde-antic wants to merge 2 commits intodevelopfrom
AIROCMLIR-185-code-coverage-is-broken

Conversation

@dorde-antic
Copy link
Contributor

@dorde-antic dorde-antic commented Feb 24, 2026

Motivation

A test rocmlir-tuning-driver/benchmark-config.mlir seems to fail on Code coverage.
When BUILD_FAT_LIBROCKCOMPILER=On, the ROCm runner is disabled and rocmlir-tuning-driver was not built. Add support so the tuning driver can be built and tested in that configuration.

Technical Details

  • Add ROCMLIR_BUILD_TUNING_DRIVER option; set it ON by default when BUILD_FAT_LIBROCKCOMPILER is On so the tuning driver is built.
  • In rocmlir-tuning-driver/CMakeLists.txt: build the target when MLIR_ENABLE_ROCM_RUNNER OR ROCMLIR_BUILD_TUNING_DRIVER. Wrap target_compile_options(mlir_rocm_runtime ...) in if(MLIR_ENABLE_ROCM_RUNNER) so we do not reference the (unbuilt) mlir_rocm_runtime target in fat-lib builds.
  • In test/CMakeLists.txt: add rocmlir-tuning-driver to ROCMLIR_TEST_DEPENDS when ROCMLIR_BUILD_TUNING_DRIVER is set so check-rocmlir builds the driver and tests can find it.
  • In utils/CMakeLists.txt: add the performance subdirectory when ROCMLIR_BUILD_TUNING_DRIVER is set so benchmark-driver-utils is built and the tuning driver links successfully.

Test Plan

  • Make sure now Codecov doesn't fail on benchmark-config.mlir
  • Other CI tests

Test Result

Submission Checklist

@dorde-antic dorde-antic requested a review from causten as a code owner February 24, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant